Skip to content

Add 1.1 line to the PR template#10647

Merged
gilles-peskine-arm merged 4 commits intoMbed-TLS:developmentfrom
gilles-peskine-arm:github-pr-template-add-4.1-mbedtls
Apr 15, 2026
Merged

Add 1.1 line to the PR template#10647
gilles-peskine-arm merged 4 commits intoMbed-TLS:developmentfrom
gilles-peskine-arm:github-pr-template-add-4.1-mbedtls

Conversation

@gilles-peskine-arm
Copy link
Copy Markdown
Contributor

Starting now, pull requests may need backports to the upcoming LTS branches (TF-PSA-Crypto 1.1 and Mbed TLS 4.1).

PR checklist

Signed-off-by: Gilles Peskine <Gilles.Peskine@arm.com>
Signed-off-by: Gilles Peskine <Gilles.Peskine@arm.com>
@gilles-peskine-arm gilles-peskine-arm added needs-review Every commit must be reviewed by at least two team members, needs-reviewer This PR needs someone to pick it up for review priority-high High priority - will be reviewed soon size-xs Estimated task size: extra small (a few hours at most) labels Mar 19, 2026
Comment thread .github/pull_request_template.md Outdated
- [ ] **TF-PSA-Crypto PR** provided # | not required because:
- [ ] **framework PR** provided Mbed-TLS/mbedtls-framework# | not required
- [ ] **3.6 PR** provided # | not required because:
- [ ] **prerequisite TF-PSA-Crypto PR** provided # | not required because:
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- [ ] **prerequisite TF-PSA-Crypto PR** provided # | not required because:
- [ ] **prerequisite TF-PSA-Crypto PR** provided Mbed-TLS/TF-PSA-Crypto# | not required because:

Comment thread .github/pull_request_template.md Outdated
- [ ] **prerequisite TF-PSA-Crypto PR** provided # | not required because:
- [ ] **prerequisite framework PR** provided Mbed-TLS/mbedtls-framework# | not required
- [ ] **backport 4.1 PR** provided # | not required because:
- [ ] **prerequisite backport 1.1 PR** provided # | not required because:
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As in the other pr I would make them simpler lts backport xx but it is not a strong ask

Signed-off-by: Gilles Peskine <Gilles.Peskine@arm.com>
ronald-cron-arm
ronald-cron-arm previously approved these changes Apr 1, 2026
Copy link
Copy Markdown
Contributor

@ronald-cron-arm ronald-cron-arm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

mpg
mpg previously approved these changes Apr 9, 2026
Copy link
Copy Markdown
Contributor

@mpg mpg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@github-project-automation github-project-automation Bot moved this from In Development to Has Approval in Roadmap pull requests (new board) Apr 9, 2026
@mpg mpg added approved Design and code approved - may be waiting for CI or backports and removed needs-review Every commit must be reviewed by at least two team members, needs-reviewer This PR needs someone to pick it up for review labels Apr 9, 2026
Copy link
Copy Markdown
Contributor

@minosgalanakis minosgalanakis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not blocking

I would propose we try to align with my other comment in TF-PSA-Crypto

Grouping the categories in a sensical order of this repo -> then depedencies -> then backports

changelog provided | not required because:
development PR provided # | not required because: 
TF-PSA-Crypto development PR provided Mbed-TLS/TF-PSA-Crypto# | not required because:
 framework PR provided Mbed-TLS/mbedtls-framework# | not required
backport 4.1 PR provided # | not required because:
backport 3.6 PR provided # | not required because:
prerequisite backport 1.1 PR provided Mbed-TLS/TF-PSA-Crypto# | not required because:
tests provided | not required because:

I am not blocking this pr but if you agree, I could raise follow-up prs following this design

Following the team discussion, don't suggest "prerequisite" or "consuming"
in the template. Suggest linking all the pull requests in a group
everywhere.

Signed-off-by: Gilles Peskine <Gilles.Peskine@arm.com>
@gilles-peskine-arm gilles-peskine-arm dismissed stale reviews from mpg and ronald-cron-arm via 6b31bc6 April 13, 2026 12:57
@gilles-peskine-arm gilles-peskine-arm added needs-review Every commit must be reviewed by at least two team members, and removed approved Design and code approved - may be waiting for CI or backports labels Apr 13, 2026
Copy link
Copy Markdown
Contributor

@mpg mpg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@gilles-peskine-arm gilles-peskine-arm added approved Design and code approved - may be waiting for CI or backports and removed needs-review Every commit must be reviewed by at least two team members, labels Apr 15, 2026
@gilles-peskine-arm gilles-peskine-arm added this pull request to the merge queue Apr 15, 2026
Merged via the queue into Mbed-TLS:development with commit 8bf8941 Apr 15, 2026
4 checks passed
@github-project-automation github-project-automation Bot moved this from Has Approval to Done in Roadmap pull requests (new board) Apr 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Design and code approved - may be waiting for CI or backports priority-high High priority - will be reviewed soon size-xs Estimated task size: extra small (a few hours at most)

Development

Successfully merging this pull request may close these issues.

4 participants