Support DESTDIR for install and add build-system test#10631
Open
yiwu0b11 wants to merge 13 commits intoMbed-TLS:developmentfrom
Open
Support DESTDIR for install and add build-system test#10631yiwu0b11 wants to merge 13 commits intoMbed-TLS:developmentfrom
yiwu0b11 wants to merge 13 commits intoMbed-TLS:developmentfrom
Conversation
Signed-off-by: Yi Wu <yi.wu2@arm.com>
yiwu0b11
added
needs-work
needs-ci
|
Also |
freebsd-git
pushed a commit
to freebsd/freebsd-ports
that referenced
this pull request
Mar 7, 2026
Not respect DESTDIR during create symlinks libmbedcrypto.so*. Upstream issue: Mbed-TLS/mbedtls#10627 - Add fix for installing libmbedcrypto.so from upstream pool request: Mbed-TLS/mbedtls#10631 - Add strip for libmbedcrypto.so. - Sort pkg-plist. PR: 293653 Approved by: Paavo-Einari Kaipila <pkaipila@gmail.com> (maintainer)
Signed-off-by: Yi Wu <yi.wu2@arm.com>
5 tasks
Signed-off-by: Yi Wu <yi.wu2@arm.com>
Signed-off-by: Yi Wu <yi.wu2@arm.com>
yiwu0b11
added
needs-review
bjwtaylor
reviewed
Mar 17, 2026
Signed-off-by: Yi Wu <yi.wu2@arm.com>
bjwtaylor
previously approved these changes
Apr 8, 2026
bjwtaylor
reviewed
Apr 8, 2026
Signed-off-by: Yi Wu <yi.wu2@arm.com>
gilles-peskine-arm
added
the
priority-medium
github-project-automation
Bot
moved this to In Development
in Non-roadmap pull requests
gilles-peskine-arm
requested changes
Apr 10, 2026
Contributor
gilles-peskine-arm
left a comment
gilles-peskine-arm
left a comment
There was a problem hiding this comment.
LGTM for the fix. The non-regression test is fine but the code is a bit too complicated.
gilles-peskine-arm
added
needs-work
needs-backports
Contributor
|
Note that we should side-port the test, and presumably the fix, to TF-PSA-Crypto. |
Signed-off-by: Yi Wu <yi.wu2@arm.com>
Signed-off-by: Yi Wu <yi.wu2@arm.com>
gilles-peskine-arm
requested changes
Apr 13, 2026
Contributor
gilles-peskine-arm
left a comment
gilles-peskine-arm
left a comment
There was a problem hiding this comment.
LGTM for what this is attempting to do. The CI is complaining and I haven't found the mistake that it found.
Signed-off-by: Yi Wu <yi.wu2@arm.com>
Signed-off-by: Yi Wu <yi.wu2@arm.com>
gilles-peskine-arm
added
needs-review
gilles-peskine-arm
requested changes
Apr 14, 2026
Contributor
gilles-peskine-arm
left a comment
gilles-peskine-arm
left a comment
There was a problem hiding this comment.
LGTM except the if structure
|
|
||
| install_lib_path="$OUT_OF_SOURCE_DIR/stage/usr/${install_lib_subdir}" | ||
|
|
||
| if [[ "$OSTYPE" != darwin* ]]; then |
Contributor
There was a problem hiding this comment.
Now the else branch is unreachable. Also, please avoid stacking negations, as they make the code harder to understand. In general, avoid if not x then A else B: write if x then B else A. (Keep if not x then A when there's no else clause.) So here:
if [[ "$OSTYPE" == "darwin" ]]; then …
Signed-off-by: Yi Wu <yi.wu2@arm.com>
Signed-off-by: Yi Wu <yi.wu2@arm.com>
gilles-peskine-arm
previously approved these changes
Apr 15, 2026
Contributor
gilles-peskine-arm
left a comment
gilles-peskine-arm
left a comment
There was a problem hiding this comment.
LGTM but we could simplify the validation of the link a bit
Signed-off-by: Yi Wu <yi.wu2@arm.com>
7 tasks
bjwtaylor
approved these changes
Apr 16, 2026
github-project-automation
Bot
moved this from In Development
to Has Approval
in Non-roadmap pull requests
gilles-peskine-arm
added
approved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add support for
DESTDIRenv for build install.Tests are added
Issue: #10627
PR checklist