Add outcome analysis to TF-PSA-Crypto: framework support#292
Merged
gilles-peskine-arm merged 6 commits intoMbed-TLS:mainfrom Apr 8, 2026
Merged
Conversation
gilles-peskine-arm
added
priority-high
github-project-automation
bot
moved this to In Development
in Roadmap pull requests (new board)
Signed-off-by: Gilles Peskine <Gilles.Peskine@arm.com>
gilles-peskine-arm
force-pushed
the
analyze_outcomes-add_to_crypto-framework
branch
from
19e32bc to
25c15df
Compare
This was referenced Apr 6, 2026
Merged
Outcome analysis tasks can have "ignored" tests. Both coverage and driver tasks actually don't ignore "ignored" tests: an "ignored" test must fail the verification if it wasn't ignored. In preparation for distinguishing between truly ignored tests and tests that must be uncovered, generalize the test case lookup mechanism. No intended behavior change for `CoverageTask` and `DriverVSReference`. Signed-off-by: Gilles Peskine <Gilles.Peskine@arm.com>
For historical reasons, the "ignored" tests in outcome analysis are not actually ignored: they must not be covered, otherwise the script complains about an unnecessary exception. In coverage analysis, rename this behavior to "uncovered", and have "ignored" tests be actually ignored. In driver test parity analysis, which is now only done in the 3.6 LTS branch, keep the historical behavior Consuming branches are currently defining `IGNORED_TESTS` with the expectation that the test cases must be uncovered. They will need to rename their definition to `UNCOVERED_TESTS`. Signed-off-by: Gilles Peskine <Gilles.Peskine@arm.com>
Signed-off-by: Gilles Peskine <Gilles.Peskine@arm.com>
7 tasks
gilles-peskine-arm
force-pushed
the
analyze_outcomes-add_to_crypto-framework
branch
from
25c15df to
80a0ea9
Compare
ronald-cron-arm
requested changes
Apr 7, 2026
Contributor
ronald-cron-arm
left a comment
ronald-cron-arm
left a comment
There was a problem hiding this comment.
This looks almost good to me. I only have a few comments. While IGNORED_TESTS is not renamed to UNCOVERED_TESTS in consuming branches, we lose the ability to detect spurious uncovered tests, which seems acceptable.
7 tasks
Signed-off-by: Gilles Peskine <Gilles.Peskine@arm.com>
Signed-off-by: Gilles Peskine <Gilles.Peskine@arm.com>
gilles-peskine-arm
added
needs-review
valeriosetti
removed
the
needs-reviewer
valeriosetti
approved these changes
Apr 8, 2026
| ignored = self.ignored_tests.contains(test_suite, test_description) | ||
| if ignored: | ||
| self.note_ignored_test(results, test_suite, test_description) | ||
| continue |
Contributor
There was a problem hiding this comment.
I would have preferred to add the if ignored condition to the if case below instead of continue here, but that's a minor thing.
github-project-automation
bot
moved this from In Development
to Has Approval
in Roadmap pull requests (new board)
valeriosetti
added
approved
github-project-automation
bot
moved this from Has Approval
to Done
in Roadmap pull requests (new board)
This was referenced Apr 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Support for Mbed-TLS/TF-PSA-Crypto#729
IGNORED_TESTSin the coverage task. These tests were formerly enforced not-executed, but are now ignored.IGNORED_TESTSdefinition toUNCOVERED_TESTS. This will restore the old semantics. The consuming PR in the checklist below do this.PR checklist