Support committed generated test data and generate PQCP test data#278
Merged
valeriosetti merged 8 commits intoMbed-TLS:mainfrom Feb 27, 2026
Merged
Conversation
gilles-peskine-arm
added
needs-ci
github-project-automation
bot
moved this to In Development
in Roadmap pull requests (new board)
gilles-peskine-arm
added
needs-preceding-pr
6 tasks
gilles-peskine-arm
added
needs-review
bjwtaylor
reviewed
Feb 14, 2026
bjwtaylor
left a comment
bjwtaylor
left a comment
There was a problem hiding this comment.
Not had time to do a full review, however added a couple of initial comments/questions.
valeriosetti
removed
the
needs-reviewer
Contributor
|
Since #265 has been merged, you might rebase this PR so that we can get it merged and unlock Mbed-TLS/TF-PSA-Crypto#690 as well ;) |
Contributor
Author
|
Oh, I hadn't rebased because there was no conflict, but now there is one! Ronald and I simultaneously created a file with the same name... I'll rework this then. |
gilles-peskine-arm
force-pushed
the
generate_mldsa_tests-create
branch
from
664d22c to
8b37b49
Compare
Create a directory for scripts that are useful to maintainers, and may be invoked as part of the CI, but are not part of the normal build. These scripts may require a recent Python version and may require additional third-party modules, unlike user-facing scripts where we try to minimize requirements. Signed-off-by: Gilles Peskine <Gilles.Peskine@arm.com>
A new utility to give a common interface to committed generated files. For the time being, this module is only intended for committed generated files, and `make_generated_files_common.py` is only intended for non-committed generated files. The two may be unified at some point in the future. Signed-off-by: Gilles Peskine <Gilles.Peskine@arm.com>
As part of a long-term unification effort of generation scripts, add an option for test generators to list oudated targets without writing to files. This corresponds to functionality that the new generate_files_helper module offers. Signed-off-by: Gilles Peskine <Gilles.Peskine@arm.com>
Support check and always-update mode. Update-if-needed mode falls back to always-update mode because test_data_generation.py doesn't support update-if-needed. Signed-off-by: Gilles Peskine <Gilles.Peskine@arm.com>
Generate some basic test cases for the mldsa-native functions. Uses `dilithium_py` from https://github.com/GiacomoPope/dilithium-py (`pip install dilithium-py`), which requires Python >=3.9. Signed-off-by: Gilles Peskine <Gilles.Peskine@arm.com>
gilles-peskine-arm
force-pushed
the
generate_mldsa_tests-create
branch
from
8b37b49 to
c88127f
Compare
gilles-peskine-arm
removed
the
needs-preceding-pr
Contributor
Author
|
I've rebased on top of the merge of #265. I also renamed |
valeriosetti
previously approved these changes
Feb 20, 2026
mpg
reviewed
Feb 24, 2026
Contributor
mpg
left a comment
mpg
left a comment
There was a problem hiding this comment.
(Taking over from Ben as a reviewer while he's away.)
Looking pretty good to me. Just a minor point that can be ignored, and a question that's probably just me missing something but I'd still like it answered before I formally approve.
Signed-off-by: Gilles Peskine <Gilles.Peskine@arm.com>
Tests using randomized signatures were currently randomized. We need the output of the script to be reproducible, so this won't do. Force randomized signatures to use a specific RNG which is reset before constructing each test case. This way, the script's output is reproducible. Signed-off-by: Gilles Peskine <Gilles.Peskine@arm.com>
5 tasks
Signed-off-by: Gilles Peskine <Gilles.Peskine@arm.com>
valeriosetti
approved these changes
Feb 27, 2026
github-project-automation
bot
moved this from In Development
to Has Approval
in Roadmap pull requests (new board)
valeriosetti
added
approved
github-project-automation
bot
moved this from Has Approval
to Done
in Roadmap pull requests (new board)
6 tasks
This was referenced Mar 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
framework/util, according to the design proposed in Design proposal: split user-invoked from CI-invoked Python scripts #272.Framework part of Mbed-TLS/TF-PSA-Crypto#690.
PR checklist
Please add the numbers (or links) of the associated pull requests for consuming branches. You can omit branches where this pull request is not needed.