Mark library as AOT-compatible#77
Merged
MartinKuschnik merged 4 commits intoMartinKuschnik:masterfrom Apr 3, 2026
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Updates project build metadata to declare WmiLight as AOT-compatible (for net8.0+) and enables AOT reference compatibility verification to eliminate IL3058 warnings when consumed by AOT-verifying projects.
Changes:
- Set
IsAotCompatible=truefor WmiLight when targeting net8.0+. - Enable
VerifyReferenceAotCompatibility=truefor WmiLight (net8.0+) and for the NetCore test app.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| WmiLight/WmiLight.csproj | Marks the library AOT-compatible for net8.0+ and turns on AOT reference verification during library builds. |
| WmiLight.TestApp-NetCore/WmiLight.TestApp-NetCore.csproj | Enables AOT reference verification for the AOT-publishing test app to validate referenced assemblies. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
MartinKuschnik
approved these changes
Apr 3, 2026
Simplified the project file to enable IsAotCompatible, VerifyReferenceAotCompatibility, and IsTrimmable only for net8.0 or later.
GitHub secrets are not available for pull requests from forks. This change introduces a SIGN_ASSEMBLY environment variable that disables assembly signing for PRs, allowing external contributors to successfully build the project without access to the private key.
MartinKuschnik
approved these changes
Apr 3, 2026
Owner
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WmiLight does not currently declare the
IsAotCompatible=trueMSBuild property. As a result, when it is referenced by a project withVerifyReferenceAotCompatibility=true, the following warning is generated:This PR sets
IsAotCompatible=true, which removes the warning.