Step 8: learn-form-schema + execute-form-batch#13
Merged
rockfordlhotka merged 1 commit intomainfrom Apr 23, 2026
Merged
Conversation
Ships the phase-1 / phase-3 form capability pair from spec §5.5 and
bumps the RockBot framework to 0.9.* for the multi-file skill API.
- FormSchema / FormField wire types with stable JSON serializer options.
- IBrowserPage.ScanFormAsync: single-JS-pass deterministic form read
(labels, validation attrs, select/radio options). Adds
SelectOptionAsync + SetCheckedAsync for the batch submit path.
- LearnFormSchemaCapability: navigate → deterministic scan →
FormSchemaEnricher (one LLM turn, can only add dependsOn + notes;
structural fields are DOM-authoritative) → persist as Skill with a
SkillResourceType.JsonSchema "schema.json" resource at
sites/{host}/forms/{slug}.
- ExecuteFormBatchCapability: resolves schema by skillRef via
ISkillStore.GetResourceAsync or inline; streams per-row progress via
AgentTaskContext.PublishStatus; default mode "abort-on-first"
(spec open-question #8 resolution), caller opts into "continue".
Success signal: optional successIndicator selector, URL-change
fallback.
- Package bump 0.8.* → 0.9.* (adds RockBot.Llm.Abstractions). Docker
image rockylhotka/rockbot-agent 0.8.5 → 0.9.11 so the peer side
gets PR #291 structured-data invoke_agent.
- Version scheme adopted: 0.2.0-alpha.8 in Directory.Build.props,
documented in CLAUDE.md Conventions.
- 14 unit tests + 1 Kestrel+Chromium end-to-end integration test.
Resolves spec open-questions #6 (typed artifacts — uses RockBot 0.9
resource files, no parallel Foragent store) and #8 (batch semantics —
abort-on-first default).
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
learn-form-schema+execute-form-batch— the phase-1 / phase-3 pair from spec §5.5 (§9.1 step 8). Learn does deterministic DOM scan + one-turn LLM enrichment (dependsOn + notes only; structure stays DOM-authoritative) and persists aFormSchemaas aSkillResourceType.JsonSchemaresource atsites/{host}/forms/{slug}. Execute resolves schemas by ref viaISkillStore.GetResourceAsync("schema.json")or inline, submits each row, streams per-row progress viaAgentTaskContext.PublishStatus, and defaults to abort-on-first with caller opt-in"continue".0.8.* → 0.9.*and therockylhotka/rockbot-agentdocker image to0.9.11(brings PR #291 structured-datainvoke_agentso RockBot can consume FormSchema JSON natively rather than as prose).{spec-major}.{spec-minor}.0-alpha.{step}— now at0.2.0-alpha.8; documented inCLAUDE.mdConventions.Test plan
dotnet build --configuration Release— 0 warnings, 0 errorsdotnet test— 80 passed, 4 skipped (existing LLM-gated), 0 failedtests/Foragent.Agent.Tests/Forms/— input validation, abort-on-first vs continue, schema round-trip throughSkillResource, required-field validation, successIndicator path, missing-resource errorFormCapabilitiesIntegrationTests— real Chromium drives real Kestrel-hosted form end-to-end (learn → persist → execute → two rows verified in POST handler); not LLM-gated since the enricher short-circuits on forms without select/radioFORAGENT_LLM_*)docker compose up --buildagainst the 0.9.11 rockbot-agent image, curl learn-form-schema + execute-form-batch end-to-end via the gateway🤖 Generated with Claude Code