Step 7: skills + memory priming (#10)#10
Merged
rockfordlhotka merged 1 commit intomainfrom Apr 23, 2026
Merged
Conversation
Wire ISkillStore + ILongTermMemory via WithSkills + WithLongTermMemory
on AgentHostBuilder. Each browser-task invocation now primes the planner
with retrieved skill and memory content (BrowserTaskPriming); on success
the capability synthesizes a learned skill at sites/{host}/learned/{slug}.
Ships an idempotent BskySeedSkillService that seeds sites/bsky.app/login
on first start. Embeddings wire through a separate ForagentEmbeddings
config section so they can live on a different subscription; missing
config downgrades retrieval to BM25-only with a single startup warning.
post-to-site removed wholesale (greenfield, no deprecation path needed):
capability, poster, tests, seed-file entries, env vars. browser-task plus
the seeded bsky skill covers the bluesky use case.
Step-6 unaided benchmark (3/3) re-verified; no regression from priming
wiring when stores are empty. Framework observations captured in
docs/framework-feedback.md — notably Skill has no tags/metadata/importance
field, so agent-learned vs human-authored distinction lives in the name.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ISkillStore+ILongTermMemoryviaWithSkills/WithLongTermMemory;browser-taskprimes the planner with retrieved content and writes a learned skill atsites/{host}/learned/{slug}on success.sites/bsky.app/loginvia idempotentBskySeedSkillService— reseed-safe across volume recreation, leaves operator edits intact.ForagentEmbeddingsconfig section (Endpoint/ModelId/ApiKey) so embeddings can live on a different subscription than the chat model; missing config downgrades retrieval to BM25-only with a single startup warning.post-to-sitewholesale — capability, poster, tests, seed-file entries, env vars.browser-task+ learned bsky skill cover the use case.Test plan
dotnet test— 51 agent + 10 browser unit tests green, including new coverage of priming injection, learned-skill write with multi-navigation gate, learned-skill skip on single-nav tasks, and seed idempotency (write once / leave existing / no-op on second start).docker compose up --buildsmoke: confirm agent card no longer advertisespost-to-site,ForagentEmbeddings not configuredwarning appears when env vars are unset,/data/foragent/skills/sites/bsky.app/loginexists on first boot of a fresh volume.Framework feedback captured
docs/framework-feedback.mdgains a Step 7 section — notably thatSkillhas no tags / metadata / importance field (agent-learned vs human-authored lives in the name prefix) andISkillStore.SearchAsynctakes an explicitfloat[]? queryEmbedding.🤖 Generated with Claude Code