Skip to content

[fix] handle geoid errors with exceptions#28

Merged
takaya-murakami-RF merged 3 commits intomainfrom
fix/llh-converter-geoid-error-handling
Apr 1, 2026
Merged

[fix] handle geoid errors with exceptions#28
takaya-murakami-RF merged 3 commits intomainfrom
fix/llh-converter-geoid-error-handling

Conversation

@rsasaki0109
Copy link
Copy Markdown
Contributor

Summary

  • replace geoid error handling in GSIGEO2011 / JPGEO2024 from exit or silent NaN to std::runtime_error
  • let callers handle out-of-range geoid errors gracefully
  • add out-of-range tests for HeightConverter and LLHConverter

Testing

  • docker exec zealous_shamir bash -lc 'source /opt/map4api/ament/install/setup.bash && source /media/sasaki/aiueo/m4e_v2/dev_260202/install/setup.bash && cd /media/sasaki/aiueo/m4e_v2/dev_260126_m4e124 && colcon --log-base .review/m4e124/log build --packages-select llh_converter --build-base .review/m4e124/build --install-base .review/m4e124/install --cmake-args -DBUILD_TESTING=OFF && source .review/m4e124/build/llh_converter/devel/setup.bash && .review/m4e124/build/llh_converter/devel/lib/llh_converter/llh_test'\n\n## Note\n- existing JPGEO2024 value comparisons in llh_test still show the same mismatch in this environment; this PR only changes error handling paths.

@rsasaki0109 rsasaki0109 marked this pull request as ready for review March 30, 2026 06:48
Copy link
Copy Markdown

@windsurf-bot windsurf-bot Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 To request another review, post a new comment with "/windsurf-review".

Comment thread src/jpgeo2024.cpp Outdated
Comment thread src/jpgeo2024.cpp Outdated
@takaya-murakami-RF takaya-murakami-RF merged commit 94e2605 into main Apr 1, 2026
@takaya-murakami-RF takaya-murakami-RF deleted the fix/llh-converter-geoid-error-handling branch April 1, 2026 06:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants