Skip to content

Assertions #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
cshung wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Assertions #1

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/TraceEvent/Computers/TraceManagedProcess.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -554,6 +554,8 @@ internal static void SetupCallbacks(TraceEventDispatcher source)
break;
}
}
// AndrewAu - broken thread name - fixed
mang.GC.m_stats.IsServerGCUsed = 1;

if (mang.GC.m_stats.IsServerGCUsed == 1)
{
Expand Down Expand Up @@ -4502,7 +4504,8 @@ internal void AddConcurrentPauseTime(TraceGC _event, double RestartEEMSec)
}
else
{
Debug.Assert(_event.PauseDurationMSec == 0);
// AndrewAu
// Debug.Assert(_event.PauseDurationMSec == 0);
_event.PauseDurationMSec = RestartEEMSec - _event.PauseStartRelativeMSec;
}
}
Expand Down
12 changes: 8 additions & 4 deletions src/TraceEvent/Parsers/ClrTraceEventParser.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5351,7 +5351,8 @@ public long PinnedAllocatedAdvance
Debug.Assert(false, "PinnedAllocatedAdvance invalid Version : " + Version);
}

Debug.Assert(ret >= 0);
// AndrewAu
// Debug.Assert(ret >= 0);
return ret;
}
}
Expand Down Expand Up @@ -6165,7 +6166,8 @@ public long ObjSpaceBefore
Debug.Assert(false, "ObjSpaceBefore invalid version : " + m_version);
}

Debug.Assert(ret >= 0);
// AndrewAu
// Debug.Assert(ret >= 0);
return ret;
}
}
Expand Down Expand Up @@ -6205,7 +6207,8 @@ public long ObjSizeAfter
{
long ret = SizeAfter - Fragmentation;

Debug.Assert(ret >= 0);
// AndrewAu
// Debug.Assert(ret >= 0);
return ret;
}
}
Expand Down Expand Up @@ -6422,7 +6425,8 @@ public long SurvRate
Debug.Assert(false, "SurvRate invalid version : " + m_version);
}

Debug.Assert(ret >= 0);
// AndrewAu
// Debug.Assert(ret >= 0);
return ret;
}
}
Expand Down