Add unit tests for parse_normalization_string#143
Add unit tests for parse_normalization_string#143phansch wants to merge 1 commit intoManishearth:masterfrom
Conversation
dtolnay
left a comment
There was a problem hiding this comment.
This should be added to upstream first -- src/tools/compiletest/src/header.rs. Then it will get picked up by this crate.
|
I'm going to close this, as I don't have enough time to work on this right now. It looks like there is currently no easy way to execute the unit tests of compiletest inside rustc by themselves. A complete |
|
Hi @phansch Sorry for not picking this up. What's needed to get it into rustc/compiletest? Just applying the patch and submitting a PR? If you don't mind, I might try to push it to rustc (obviously retaining your authorship). |
|
@laumann Just that patch, yes. But I couldn't find a way to run the compiletest unit tests of rustc locally and didn't have time to wait for a full test build. I'm not even sure if the unittests of compiletest in rustc are executed on CI, because the compiletest tool doesn't seem to be registered in the bootstrap script. I just now asked on Discord if anyone knows how to run them. |
|
Nevermind the previous comment. I went ahead and added support for running the rustc compiletest tests here: rust-lang/rust#56792 Once that's reviewed and merged, I will upstream this PR. |
This adds some unit tests for the
parse_normalization_stringfunction. Notsure if this is really needed, but there's a FIXME inside the function that
could be resolved more easily with already existing unit tests.
If this is fine, should I also add the tests to rustc's compiletest?