Open
Conversation
asinghvi17
reviewed
Feb 11, 2026
asinghvi17
reviewed
Feb 11, 2026
Co-authored-by: Anshul Singhvi <anshulsinghvi@gmail.com>
Co-authored-by: Anshul Singhvi <anshulsinghvi@gmail.com>
Author
|
I would like to post a follow-up PR for making |
Member
|
Thank you! Will try to merge this asap! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes calling
heatmap(Resampler(img::Matrix{RGB})), which is used in the example at https://docs.makie.org/dev/reference/plots/heatmap#Plotting-large-Heatmaps. Running this exampled resulted in a conversion error fromRGB{}toFloat32here.I believe this was probably broken here or here.
Type of change