Skip to content

Comments

disambiguate from 撒き餌 (same romanization)#5524

Open
rokke-git wants to merge 3 commits intoMakieOrg:masterfrom
rokke-git:patch-2
Open

disambiguate from 撒き餌 (same romanization)#5524
rokke-git wants to merge 3 commits intoMakieOrg:masterfrom
rokke-git:patch-2

Conversation

@rokke-git
Copy link

@rokke-git rokke-git commented Feb 8, 2026

Description

the main readme says "the japanese word maki-e," but maki-e is an english word.
you should either put the actual word (蒔絵, not 撒き餌 which has the same romanization),
or say something like "the word for the japanese technique of..."

Type of change

Delete options that do not apply:

  • documentation, I guess?

Checklist

  • Added an entry in CHANGELOG.md (for new features and breaking changes)
  • Added or changed relevant sections in the documentation
  • Added unit tests for new algorithms, conversion methods, etc.
  • Added reference image tests for new plotting functions, recipes, visual options, etc.

@github-project-automation github-project-automation bot moved this to Work in progress in PR review Feb 8, 2026
@SimonDanisch
Copy link
Member

image I guess this doesnt work well internationally? Same in the comments: image Maybe we just do `the word for the japanese technique of`?

@rokke-git
Copy link
Author

rokke-git commented Feb 9, 2026

I guess this doesnt work well internationally?

huh, that's kinda disappointing that browsers don't automatically load in a CJK font when you encounter characters needing one yet.

Maybe we just do the word for the japanese technique of?

ok

just curious, if you visit for example here or here do you get just a ton of boxes?

@rokke-git
Copy link
Author

actually, if I do (まき)() does it render properly?

@SimonDanisch
Copy link
Member

Nope!

@rokke-git
Copy link
Author

rokke-git commented Feb 9, 2026

looking around, it's possibly a side effect of firefox's resist fingerprinting; are you using that? I am as well but apparently my set of fonts includes cjk characters. also, was the nope only to my second attempt to do the link or are these pages also unreadable?

one more attempt: (まき)()

@SimonDanisch
Copy link
Member

I'm using brave on opensuse... Could be my browser, but I think if that's possible, I'd rather go with the English description.

@rokke-git
Copy link
Author

rokke-git commented Feb 9, 2026

I was mostly just curious; def not mozilla's rf then since brave is based on chromium. I would still kinda like to know if your browser is making any pages with japanese text unreadable or if it has some kind of metric that it's using

@ffreyer
Copy link
Collaborator

ffreyer commented Feb 9, 2026

Why not both, like wikipedia? "Maki-e (蒔絵)"

@SimonDanisch
Copy link
Member

Brave and Firefox look both broken

@rokke-git
Copy link
Author

rokke-git commented Feb 9, 2026

Brave and Firefox look both broken

oh, no; I meant that I thought maybe rf could be a reason that it doesn't load. firefox looks normal when I try it, it's just brave that looks broken. unless you tested both?

also, that's why I keep asking you if these pages look normal to you; either there's something we can do to make it work, or your browser just looks broken in the first place

@SimonDanisch
Copy link
Member

also, that's why I keep asking you if these pages look normal to you;

That was actually my answer ;) So the pages look broken both on Firefox and Brave on my PC.

@SimonDanisch
Copy link
Member

On windows it looks fine for both ;)

@ffreyer
Copy link
Collaborator

ffreyer commented Feb 9, 2026

Everything is fine for me on ubuntu firefox.

I don't think we should avoid Japanese symbols here. I would assume that they come from the same font that wikipedia etc uses, and that pretty much every windows and mac can display these. It's probably just some linux systems that can't render them, either because they use a minimal set of fonts or because they avoid proprietary fonts. But that's not our problem, that's a problem with the system setup.

@rokke-git
Copy link
Author

rokke-git commented Feb 9, 2026

the same font wikipedia etc uses

to be precise, it's the browser that chooses the font, not the website; but the website can influence this choice with the lang and font-family tags (that's what I tried adding in the earlier comments). typically, the browser will keep trying all installed fonts to fill in box-characters unless you have resist-fingerprinting enabled, which will limit attempts to a known set of fonts which (ideally) cover the set of characters that people use

it should never be a proprietary-ness problem, because noto did this amazing thing where they are trying to make a font which covers all of unicode under an open font license (broken up by language). while it doesn't cover everything; it basically covers what people actually use.

commit 2 or 3 are equally correct, you can use whichever you want. would prob be good to add lang=ja to the <ruby> tag for accessibility if you choose commit 2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Work in progress

Development

Successfully merging this pull request may close these issues.

3 participants