fix(GLMakie for Wayland): Pass correct initial resolution to avoid 10x10 fallback#5505
Open
junyixu wants to merge 1 commit intoMakieOrg:masterfrom
Open
fix(GLMakie for Wayland): Pass correct initial resolution to avoid 10x10 fallback#5505junyixu wants to merge 1 commit intoMakieOrg:masterfrom
junyixu wants to merge 1 commit intoMakieOrg:masterfrom
Conversation
…arameter * Pass target `resolution` to `empty_screen` and `singleton_screen` * Initialize `GLFW.Window` and `GLFramebuffer` with correct dimensions * Avoid window flickering and layout artifacts from 10x10 fallback
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Fixes #5501
resolutionkeyword argument throughsingleton_screenandempty_screen.GLFW.WindowandGLFramebufferwith the actual target size instead of the(10, 10)default.Screen(scene, config), grab the size from thesceneand pass it down.It works well on my end.
Type of change
Checklist