Open
Conversation
Collaborator
Benchmark ResultsSHA: d7e18456e8a3988a24d18bf16875218ebdcbd08f Warning These results are subject to substantial noise because GitHub's CI runs on shared machines that are not ideally suited for benchmarking.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a
StageCamera3D camera type which, at least for my way of thinking and visualizing a scene, allows for more intuitive camera settings as the parameters are photographically orthogonal. In a normal 3D camera, you set camera position, lookat and fov. But changing position changes camera angle and apparent size of target object. You can then counteract with fov but that's a bit annoying to do iteratively. The StageCamera decouples this by always keeping a "stage" of a fixed size around the lookat point in view. This allows to change camera angles and perspective separately. The camera distance is determined given the stage size that must be in view for the chosen fov.stage_camera.mov