fix: URL-encode workflow names with special characters#298
Draft
joelklabo wants to merge 1 commit into
Draft
Conversation
…rkflow_id Fixes MagnivOrg#254 The _resolve_workflow_id() function builds a URL like: {base_url}/workflows/{workflow_id_or_name} When workflow_id_or_name contains special characters such as slashes (e.g. 'team/my-workflow'), the slash is treated as a URL path separator by the server, resulting in a 404 or wrong-resource response. Fix: apply urllib.parse.quote(str(workflow_id_or_name), safe='') to encode ALL special characters before interpolating into the URL. The prompt-templates endpoint already received this fix (via PR MagnivOrg#291). This commit closes the remaining gap in _resolve_workflow_id.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Problem
Workflow names with slashes were not being encoded, causing API calls to fail.
Solution
Added URL encoding in the _resolve_workflow_id function.