Skip to content

updating some docs and including example projects#316

Open
NoamBenS wants to merge 4 commits into
masterfrom
add-demo-projects
Open

updating some docs and including example projects#316
NoamBenS wants to merge 4 commits into
masterfrom
add-demo-projects

Conversation

@NoamBenS
Copy link
Copy Markdown
Contributor

No description provided.

@mintlify
Copy link
Copy Markdown

mintlify Bot commented May 20, 2026

Preview deployment for your docs. Learn more about Mintlify Previews.

Project Status Preview Updated (UTC)
promptlayer 🟢 Ready View Preview May 20, 2026, 9:57 PM

💡 Tip: Enable Workflows to automatically generate PRs for you.

@NoamBenS NoamBenS self-assigned this May 20, 2026
@NoamBenS NoamBenS requested a review from bb220 May 20, 2026 22:38
@NoamBenS NoamBenS marked this pull request as ready for review May 20, 2026 22:38
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 0ec7b73cb7

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

You can also call the app route directly:

```bash
curl -X POST /api/agent \
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Add explicit host to sample curl command

The README’s direct API test command uses a relative path (/api/agent) without a scheme/host, so running it from a shell fails with a URL error instead of hitting the local FastAPI server. This breaks the primary manual verification path for the example; the command should include the local server URL (for example http://127.0.0.1:8000/api/agent).

Useful? React with 👍 / 👎.

@bb220
Copy link
Copy Markdown
Collaborator

bb220 commented May 21, 2026

@NoamBenS can you rename the top-level sub folders to follow this pattern <framework-name>-telemetry

Ex. langchain-telemetry/, claude-agent-sdk-python-telemetry/, etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants