[core] refactor: enable ESLint rule require-await and handle detected issues#4038
Merged
rejas merged 1 commit intoMagicMirrorOrg:developfrom Feb 25, 2026
Merged
Conversation
KristjanESPERANTO
force-pushed
the
require-await
branch
from
e21a78c to
a8205a9
Compare
Remove unnecessary async keywords from functions that don't use await.
KristjanESPERANTO
force-pushed
the
require-await
branch
from
a8205a9 to
25c8573
Compare
rejas
approved these changes
Feb 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enable the
require-awaitESLint rule. Async functions withoutawaitare just regular functions with extra overhead — marking themasyncadds implicit Promise wrapping, can hide missingreturnstatements, and misleads readers into expecting asynchronous behavior where there is none.While fixing the violations, I removed unnecessary
asynckeywords from source files and from various test callbacks that never usedawait.