Conversation
Co-authored-by: MR-Addict <75357598+MR-Addict@users.noreply.github.com>
Co-authored-by: MR-Addict <75357598+MR-Addict@users.noreply.github.com>
Co-authored-by: MR-Addict <75357598+MR-Addict@users.noreply.github.com>
Co-authored-by: MR-Addict <75357598+MR-Addict@users.noreply.github.com>
|
@copilot will the built binary supports mdbook version 0.4.x |
No, the built binary will only support mdbook 0.5.x. The preprocessor is compiled against mdbook 0.5.x types ( Users will need to upgrade their mdbook installation to 0.5.x to use this version of mdbook-embedify. If they need to stay on mdbook 0.4.x, they should use an older version of mdbook-embedify (0.2.18 or earlier with the previous dependency on |
|
@copilot The compilation does pass, fix that |
Co-authored-by: MR-Addict <75357598+MR-Addict@users.noreply.github.com>
Fixed in commit 8a33945. The CI workflows were trying to extract the mdbook version using |
|
@copilot The action text still doesn’t pass |
Could you provide more details about what's failing? The changes I made should:
Is the issue:
If you have CI logs or error messages, that would help me fix the issue more quickly. |
|
@copilot here’s the raw logs |
Co-authored-by: MR-Addict <75357598+MR-Addict@users.noreply.github.com>
Fixed in commit 0e39e54. The issue was that CI was using a cached mdbook 0.4.x installation, but the preprocessor was compiled against mdbook 0.5.x types. This caused a JSON deserialization error: "missing field The workflows now:
This ensures the mdbook binary and preprocessor are always compatible. |
|
@copilot still doesn’t pass, I think you can test yourself. Also here’s the log file |
Co-authored-by: MR-Addict <75357598+MR-Addict@users.noreply.github.com>
Fixed in commit 0e28638. The issue was that mdbook 0.5.x changes its working directory to the book root before executing preprocessors, so the relative path Changed the path to |
…rkflows and update documentation for include app
Summary
Successfully updated mdbook-embedify from mdbook 0.4.51 to 0.5.2 compatibility. All tests pass, code review is clean, no security vulnerabilities detected.
Fixed CI issues:
../../target/release/mdbook-embedify) since mdbook 0.5.x changes working directory to the book root before executing preprocessorsOriginal prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.