Fix compilation for python 10 and numpy 2.2.6#118
Open
MarilynKeller wants to merge 1 commit intoMPI-IS:masterfrom
Open
Fix compilation for python 10 and numpy 2.2.6#118MarilynKeller wants to merge 1 commit intoMPI-IS:masterfrom
MarilynKeller wants to merge 1 commit intoMPI-IS:masterfrom
Conversation
|
For who may want to install directly: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This merge request fixes a compilation error that occurred when building with:
The issue was due to incorrect type casting when passing
PyObject*toPyArray_DATAandPyArray_DIMS, which now expects a const PyArrayObject* as of recent NumPy versions.Changes
Explicit cast added in mesh/src/*.cpp
Makefile updated:
As --install-option is not supported by modern pip