feat: add china-mwr (水利部) and china-moa (农业农村部) data sources#35
Open
firstdata-dev wants to merge 1 commit intoMLT-OSS:mainfrom
Open
feat: add china-mwr (水利部) and china-moa (农业农村部) data sources#35firstdata-dev wants to merge 1 commit intoMLT-OSS:mainfrom
firstdata-dev wants to merge 1 commit intoMLT-OSS:mainfrom
Conversation
- china-mwr: Ministry of Water Resources - water resources statistics, annual bulletins, supply/consumption, flood control, irrigation data - china-moa: Ministry of Agriculture and Rural Affairs - agricultural statistics, crop production, livestock, rural economy data Both sources are authoritative government sources (authority_level: government) with national geographic scope and annual update frequency.
firstdata-dev
commented
Mar 6, 2026
Contributor
Author
firstdata-dev
left a comment
firstdata-dev
left a comment
There was a problem hiding this comment.
✅ Review 通过
- Schema 合规，双语描述完整
- domains 格式正确（空格分隔）✅
- 分类路径合理：水利部 → china/resources/water/，农业农村部 → china/agriculture/
- 政府网站境外不可达属正常情况
注意：没有包含索引更新文件，合并后需要触发 build_indexes.py 更新索引。
LGTM，建议合并。
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add two new authoritative Chinese government data sources:
1. china-mwr — Ministry of Water Resources (水利部)
firstdata/sources/china/resources/water/china-mwr.json2. china-moa — Ministry of Agriculture and Rural Affairs (农业农村部)
firstdata/sources/china/economy/agriculture/china-moa.jsonValidation
make validate— all 158 IDs pass schema validationmake check-ids— no duplicate IDsmake check-domains— domain consistency confirmed