Fix: Optimize LensingDataset data loading and prevent NaN loss#167
Open
kamilansri wants to merge 1 commit intoML4SCI:mainfrom
Open
Fix: Optimize LensingDataset data loading and prevent NaN loss#167kamilansri wants to merge 1 commit intoML4SCI:mainfrom
kamilansri wants to merge 1 commit intoML4SCI:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses a critical mathematical flaw in the
LensingDatasetnormalization step that could lead to division-by-zero errors (resulting inNaNloss during training). It also refactors the data loading logic to be more robust across different operating systems and significantly more memory-efficient.Changes Made
NaNrisk in normalization: Added a small epsilon value (1e-8) to the denominator during min-max normalization. This prevents division-by-zero crashes if an image array is completely flat/blank (where min equals max).directory+selected_class) withos.path.jointo prevent malformed paths if the directory string is missing a trailing slash.np.array([np.load(...)])wrapper. Now usingtorch.from_numpy()to convert the array directly into a tensor without unnecessary memory copying..unsqueeze(0)to correctly add the channel dimension, and chained.float()to ensure the output tensor isfloat32(saving memory and compute compared tofloat64).