Update dependency devise to v5 [SECURITY]#1499
Open
renovate[bot] wants to merge 1 commit intomainfrom
Open
Conversation
9cabaf4 to
1d442cd
Compare
1d442cd to
d78c7c5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains the following updates:
4.9.4→5.0.3GitHub Vulnerability Alerts
CVE-2026-32700
Impact
A race condition in Devise's Confirmable module allows an attacker to confirm an email address they do not own. This affects any Devise application using the
reconfirmableoption (the default when using Confirmable with email changes).By sending two concurrent email change requests, an attacker can desynchronize the
confirmation_tokenandunconfirmed_emailfields. The confirmation token is sent to an email the attacker controls, but theunconfirmed_emailin the database points to a victim's email address. When the attacker uses the token, the victim's email is confirmed on the attacker's account.Patches
This is patched in Devise v5.0.3. Users should upgrade as soon as possible.
Workarounds
Applications can override this specific method from Devise models to force
unconfirmed_emailto be persisted when unchanged: (assuming your model isUser)Note: Mongoid does not seem to respect that
will_change!should force the attribute to be persisted, even if it did not really change, so you might have to implement a workaround similar to Devise by settingchanged_attributes["unconfirmed_email"] = nilas well.Severity
CVSS:4.0/AV:N/AC:H/AT:N/PR:L/UI:N/VC:N/VI:H/VA:N/SC:N/SI:N/SA:NRelease Notes
heartcombo/devise (devise)
v5.0.3Compare Source
v5.0.2Compare Source
sign_in_after_change_passwordbehaviour. #5825RegistrationsControllernow relies on a setting from the:registerablemodule. These users were configuring their own routes pointing to theRegistrationsControllerfor resource edit/update actions mostly, without relying on the other registration actions (e.g. user sign up.), so they omitted:registerablefrom the model declaration. While using just a portion of the controller functionality is a valid use for:registerable(or any module really), the module must still be declared in the model, much like the other modules must be declared if you plan on using just a portion of their behavior. Please check this issue for more info.sign_in_after_reset_password?check hook to passwords controller, to allow it to be customized by users. #5826v5.0.1Compare Source
E-Mailon invalid authentication messages caused by previous fix for incorrect grammar #5822v5.0.0Compare Source
no changes
Configuration
📅 Schedule: (UTC)
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR was generated by Mend Renovate. View the repository job log.