Skip to content

test#1266

Merged
sbryngelson merged 2 commits intomasterfrom
test-claude
Feb 25, 2026
Merged

test#1266
sbryngelson merged 2 commits intomasterfrom
test-claude

Conversation

@sbryngelson
Copy link
Member

@sbryngelson sbryngelson commented Feb 25, 2026

test pr

Summary by CodeRabbit

  • Chores

    • Optimized code review workflow configuration for improved efficiency.
  • Documentation

    • Clarified parameter count information in help text.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 25, 2026

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 0ce8382 and c0a88cd.

📒 Files selected for processing (2)
  • .github/workflows/claude-code-review.yml
  • CLAUDE.md

📝 Walkthrough

Walkthrough

Configuration adjustments to the Claude Code Review workflow and a minor documentation text update. The workflow now limits agent turns to 10 (from 80), removes a PATH override, adds clarifying comments about sandboxing, and specifies PR comment title format.

Changes

Cohort / File(s) Summary
Workflow Configuration
.github/workflows/claude-code-review.yml
Removed env PATH override, reduced claude_args max-turns from 80 to 10, added explanatory comments about sandbox behavior, and updated PR comment directive to require title "Claude Code Review".
Documentation
CLAUDE.md
Removed approximation symbol (~) from parameter count in help text (3,400 case parameters).

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~5 minutes

Possibly related PRs

Suggested labels

size:S

Poem

🐰 A workflow refined, ten turns suffice,
Comments now titled with precision and spice,
No tilde to fudge, just honest numbers,
The code review hops to quicker slumbers! ✨

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch test-claude

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Updated Claude Code Review workflow to modify max turns and comment behavior.
@sbryngelson sbryngelson marked this pull request as ready for review February 25, 2026 19:58
Copilot AI review requested due to automatic review settings February 25, 2026 19:58
@sbryngelson sbryngelson merged commit 9652f08 into master Feb 25, 2026
27 of 30 checks passed
@sbryngelson sbryngelson deleted the test-claude branch February 25, 2026 19:58
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR makes small documentation and CI workflow adjustments related to the Claude Code Review tooling.

Changes:

  • Updates the ./mfc.sh params help text in CLAUDE.md to remove the approximation marker.
  • Simplifies the Claude code review GitHub Actions workflow by removing a PATH override and reducing --max-turns, and tweaks the in-workflow prompt text.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
CLAUDE.md Updates CLI usage documentation for the params command.
.github/workflows/claude-code-review.yml Adjusts Claude Code Review action configuration and prompt instructions.

# Other
./mfc.sh validate case.py # Validate case file without running
./mfc.sh params <query> # Search ~3,400 case parameters
./mfc.sh params <query> # Search 3,400 case parameters
Copy link

Copilot AI Feb 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

./mfc.sh params line now says "Search 3,400 case parameters" (exact), but later in the same doc the source-of-truth count is described as "~3,400". Consider keeping these consistent (either both approximate or both exact) to avoid the doc getting stale as the parameter count changes.

Suggested change
./mfc.sh params <query> # Search 3,400 case parameters
./mfc.sh params <query> # Search ~3,400 case parameters

Copilot uses AI. Check for mistakes.
plugins: "code-review@claude-code-plugins"

# NOTE: do NOT use --dangerouslyDisableSandbox (it can crash the CLI).
# This flag is for non-interactive CI runs (bypasses approval prompts).
Copy link

Copilot AI Feb 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The comment above claude_args says "This flag is for non-interactive CI runs (bypasses approval prompts)", but the flag being warned about there is --dangerouslyDisableSandbox (which is not being used). The approval-prompt bypass behavior belongs to --dangerously-skip-permissions; please reword/move the comment so it's unambiguous which flag it refers to.

Suggested change
# This flag is for non-interactive CI runs (bypasses approval prompts).
# The --dangerously-skip-permissions flag is for non-interactive CI runs (bypasses approval prompts).

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants