-
Notifications
You must be signed in to change notification settings - Fork 132
Add CLI visualization command (./mfc.sh viz) #1233
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
sbryngelson
wants to merge
66
commits into
MFlowCode:master
Choose a base branch
from
sbryngelson:viz-fast
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+3,889
−524
Draft
Changes from all commits
Commits
Show all changes
66 commits
Select commit
Hold shift + click to select a range
562919f
Add `./mfc.sh viz` command for CLI visualization of post-processed ou…
sbryngelson 97f3bc7
Fix viz: validate variable name and fix lint/spelling issues
sbryngelson 4d6cc7a
Fix MP4 frame directory to use output path instead of case directory
sbryngelson a1e5515
Fix Silo-HDF5 reader to parse Named Datatype structure correctly
sbryngelson a9fb166
Fix multi-processor assembly and Silo data ordering
sbryngelson b6e4c2f
Use imageio-ffmpeg for MP4 rendering instead of system ffmpeg
sbryngelson e008f85
Add documentation for ./mfc.sh viz command
sbryngelson 9f7da71
Address code review feedback from CodeRabbit
sbryngelson c5e683e
Fix --step input validation and clarify inclusive range in docs
sbryngelson a239780
Guard LogNorm against non-positive data in log-scale rendering
sbryngelson a4940dc
Harden readers and CLI error handling
sbryngelson ae3e48d
Add viz to CLI reference doc generation categories
sbryngelson cbfd749
Harden binary reader: EOF check, header validation, varname union, st…
sbryngelson 838c826
Fix MP4 opts mutation, frame cleanup safety, silo skip warning
sbryngelson 938fc74
Harden viz: record validation, error handling, and robustness
sbryngelson 33721e8
Guard LogNorm against NaN data, harden frame cleanup
sbryngelson 010e3de
Fix KeyError in MP4 rendering and require --step for render
sbryngelson 8708571
Use MFCException instead of sys.exit, remove imageio from deps
sbryngelson 06e3dc8
Fix frame cleanup race, value0 guard, and clean up warnings imports
sbryngelson 2adf585
Replace deprecated imageio.get_writer with imageio.mimwrite
sbryngelson 99b5b75
Add h5py/imageio deps, cmap completion, quick-start guide, simplify i…
sbryngelson ff89b90
Suppress ffmpeg diagnostic noise in MP4 output
sbryngelson c8bd1a5
Fix AttributeError: numpy.void has no .get(), use [] indexing
sbryngelson 12a71f0
Expand --cmap completion to full matplotlib colormap list
sbryngelson 4b65c13
Add --interactive mode: Dash web UI for 3D/2D/1D visualization
sbryngelson d26623c
Fix interactive viz freezing: switch sliders to updatemode=mouseup
sbryngelson 7901c68
Fix 3D aspect ratio and add blast wave example
sbryngelson 197d1ca
Revert example changes from previous commit
sbryngelson b66dbda
Add variable picker to interactive viz UI
sbryngelson 3e0eb8d
Fix precheck failures in interactive.py
sbryngelson 7ef8823
Add tiled 1D rendering, grid lines, and adaptive 2D figsize
sbryngelson e5c9c1a
Use LaTeX-style fonts and math-mode axis labels in plots
sbryngelson 3d10bb9
Validate timestep in --list-vars before assembly
sbryngelson db19ff4
Add LaTeX label lookup for MFC variable names in plots
sbryngelson 499274c
Add viz unit tests with checked-in 1D/2D/3D fixture data
sbryngelson 45afb8b
Merge remote-tracking branch 'origin/master' into viz-fast
sbryngelson d94f437
Fix ghost-cell dedup, 3D memory guard, and interactive host binding
sbryngelson 32cbd52
Add terminal TUI (--tui) for 1D/2D interactive visualization
sbryngelson 4b78bf1
Fix MP4 memory usage and remove cmcrameri-dependent colormaps
sbryngelson 667ca10
Add log scale, freeze range, and autoplay to TUI
sbryngelson 2498a0f
Fix Python 3.10+ compatibility and packaging issues
sbryngelson 42d0923
Add sensible defaults to ./mfc.sh viz flags
sbryngelson fb065bc
Improve viz error messages: colormap validation, step hints, missing …
sbryngelson b63d392
Add TUI section to viz docs and update defaults
sbryngelson 085437e
Fix log scale: add 1D support, fix TUI vmin clamping, add log indicators
sbryngelson 12e09fa
Remove [log] suffix from PNG/video colorbar labels
sbryngelson 911b10a
Add TUI frozen indicator; fix spell check scanning build_test/
sbryngelson 3fec6f1
Address review: bounded caches, MP4 cleanup, avoid double-read
sbryngelson caacd92
Add unit tests for _steps_hint, _validate_cmap, TUI cache, and log scale
sbryngelson 189dc24
Raise on missing processor files instead of silently skipping
sbryngelson 85c715e
Fix dedup large-domain math, add --host flag, add multi-rank assembly…
sbryngelson a84b3f3
Move viz deps to optional extra; install on first ./mfc.sh viz
sbryngelson 1d12175
Address Claude Code review: bounded caches, MP4 cleanup, avoid double…
sbryngelson 45070f9
Add render_2d_tiled: tile all variables for 2D --var all
sbryngelson 59086c7
Add comma-list and ellipsis step syntax to --step
sbryngelson dc02a34
Fix MP4 frame-size inconsistency from bbox_inches='tight'
sbryngelson 475bfd7
Fix MP4 uniform frame size: scan all frames for max dims
sbryngelson 412f36a
Address review: normalize MP4 frames to RGB; test negative _dedup dec…
sbryngelson 7d04f9a
TUI 2D: preserve physical domain aspect ratio in heatmap
sbryngelson a67bc37
Remove legacy viz scripts and viz_legacy module; fix lint for viz extras
sbryngelson 9f0f3dc
Add timeout to viz deps install subprocess
sbryngelson 7db60f8
Use MFCException in tui.py; remove 2>/dev/null from lint.sh
sbryngelson 42797c6
Merge branch 'master' into viz-fast
sbryngelson 4924a13
Address bot review: sentinels, seaborn, dep cleanup, TUI docs, guards
sbryngelson 3363995
Fix bot review findings #5 and #7
sbryngelson ac585c4
Address PR review findings: thread safety, precision, error handling,…
sbryngelson File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.