Skip to content

Fix missing private clauses in 3D viscous GPU loops #1225

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sbryngelson wants to merge 8 commits into
base: master
Choose a base branch
from
+6 −6
Open

Fix missing private clauses in 3D viscous GPU loops #1225

Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
81e67a4
Fix missing private clauses in 3D viscous GPU loops
sbryngelson Feb 21, 2026
e6c0e29
Add loop indices to private clauses in 3D viscous GPU loops
sbryngelson Feb 21, 2026
69b0e93
Add missing q to GPU_PARALLEL_LOOP private lists
sbryngelson Feb 23, 2026
7fcb80a
Fix errant space before comma in GPU private clause list
sbryngelson Feb 24, 2026
1e474f1
Merge branch 'master' into fix/viscous-3d-gpu-private
sbryngelson Feb 25, 2026
b63f36b
Merge branch 'master' into fix/viscous-3d-gpu-private
sbryngelson Feb 25, 2026
9b5101e
Merge branch 'master' into fix/viscous-3d-gpu-private
sbryngelson Feb 25, 2026
dca6c2f
Fix typos in m_viscous.fpp
sbryngelson Feb 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions src/simulation/m_viscous.fpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,7 @@ contains

#:if not MFC_CASE_OPTIMIZATION or num_dims > 1
if (shear_stress) then ! Shear stresses
$:GPU_PARALLEL_LOOP(collapse=3, private='[i,j,k,l,rho_visc, gamma_visc, pi_inf_visc, alpha_visc_sum ,alpha_visc, alpha_rho_visc, Re_visc, tau_Re]')
$:GPU_PARALLEL_LOOP(collapse=3, private='[i,j,k,l,q,rho_visc, gamma_visc, pi_inf_visc, alpha_visc_sum, alpha_visc, alpha_rho_visc, Re_visc, tau_Re]')
do l = is3_viscous%beg, is3_viscous%end
do k = -1, 1
do j = is1_viscous%beg, is1_viscous%end
Expand Down Expand Up @@ -212,7 +212,7 @@ contains

#:if not MFC_CASE_OPTIMIZATION or num_dims > 1
if (bulk_stress) then ! Bulk stresses
$:GPU_PARALLEL_LOOP(collapse=3, private='[i,j,k,l,rho_visc, gamma_visc, pi_inf_visc, alpha_visc_sum ,alpha_visc, alpha_rho_visc, Re_visc, tau_Re]')
$:GPU_PARALLEL_LOOP(collapse=3, private='[i,j,k,l,q,rho_visc, gamma_visc, pi_inf_visc, alpha_visc_sum, alpha_visc, alpha_rho_visc, Re_visc, tau_Re]')
do l = is3_viscous%beg, is3_viscous%end
do k = -1, 1
do j = is1_viscous%beg, is1_viscous%end
Expand Down Expand Up @@ -319,7 +319,7 @@ contains
#:if not MFC_CASE_OPTIMIZATION or num_dims > 2

if (shear_stress) then ! Shear stresses
$:GPU_PARALLEL_LOOP(collapse=3, private='[alpha_visc, alpha_rho_visc, Re_visc, tau_Re]')
$:GPU_PARALLEL_LOOP(collapse=3, private='[i,j,k,l,q,rho_visc, gamma_visc, pi_inf_visc, alpha_visc_sum, alpha_visc, alpha_rho_visc, Re_visc, tau_Re]')
do l = is3_viscous%beg, is3_viscous%end
do k = -1, 1
do j = is1_viscous%beg, is1_viscous%end
Expand Down Expand Up @@ -428,7 +428,7 @@ contains
end if

if (bulk_stress) then ! Bulk stresses
$:GPU_PARALLEL_LOOP(collapse=3, private='[alpha_visc, alpha_rho_visc, Re_visc, tau_Re]')
$:GPU_PARALLEL_LOOP(collapse=3, private='[i,j,k,l,q,rho_visc, gamma_visc, pi_inf_visc, alpha_visc_sum, alpha_visc, alpha_rho_visc, Re_visc, tau_Re]')
do l = is3_viscous%beg, is3_viscous%end
do k = -1, 1
do j = is1_viscous%beg, is1_viscous%end
Expand Down Expand Up @@ -1564,12 +1564,12 @@ contains
real(wp) :: divergence
integer :: l, q ! iterators

! zero the viscous stress, collection of velocity diriviatives, and spacial finite differences
! zero the viscous stress, collection of velocity derivatives, and spatial finite differences
viscous_stress_tensor = 0._wp
velocity_gradient_tensor = 0._wp
dx = 0._wp

! get the change in x used in the finite difference equaiont
! get the change in x used in the finite difference equation
dx(1) = 0.5_wp*(x_cc(i + 1) - x_cc(i - 1))
dx(2) = 0.5_wp*(y_cc(j + 1) - y_cc(j - 1))
if (num_dims == 3) then
Expand Down
Loading