-
Notifications
You must be signed in to change notification settings - Fork 0
Add Meteor 26.x parser profile support #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
4299838
Add Meteor 26x parser profile support
GhostTypes 9e5afde
Restore profile-specific serialization contracts
GhostTypes b60cfa5
Run CI against 26x profile
GhostTypes 9a6f154
Use Gradle 9 for Java 25 CI
GhostTypes 9a16cc1
Make 26x stub generation reproducible from clean state
GhostTypes a5f7606
Finish 26x settings migration; remove Yarn from shared sources
GhostTypes d5a9791
Curate fixture set to known 26.x addons only
GhostTypes fb38eb0
Fix registry/placeholder collisions flagged in PR review
GhostTypes File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
28 changes: 28 additions & 0 deletions
28
src/main/java/com/cope/addonparser/profile/MappingProfile.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,28 @@ | ||
| package com.cope.addonparser.profile; | ||
|
|
||
| import java.util.Locale; | ||
|
|
||
| public enum MappingProfile { | ||
| LEGACY, | ||
| MOJMAP_26X; | ||
|
|
||
| public static final String SYSTEM_PROPERTY = "addonparser.profile"; | ||
|
|
||
| public static MappingProfile fromString(String value) { | ||
| if (value == null || value.isBlank()) return MOJMAP_26X; | ||
| return switch (value.trim().toLowerCase(Locale.ROOT)) { | ||
| case "legacy", "1.21", "1.21.x", "yarn" -> LEGACY; | ||
| case "26x", "26", "26.1", "mojmap", "mojmap_26x" -> MOJMAP_26X; | ||
| default -> throw new IllegalArgumentException( | ||
| "Unknown mapping profile: " + value + " (expected 'legacy' or '26x')"); | ||
| }; | ||
| } | ||
|
|
||
| public static MappingProfile fromSystemProperty() { | ||
| return fromString(System.getProperty(SYSTEM_PROPERTY)); | ||
| } | ||
|
|
||
| public String cliValue() { | ||
| return this == LEGACY ? "legacy" : "26x"; | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While
dev.jfronny.meteoradditions.util.IModulehas been added to the parent-first list,meteordevelopment.meteorclient.*classes are still missing. If an addon jar bundles any Meteor Client classes (even by accident), it could lead toClassCastExceptionwhen the scanner tries to interact with them. It is generally safer to include the entiremeteordevelopment.meteorclient.package in the parent-first delegation list for this scanner to ensure type consistency between the scanner and the loaded addon.