Stop and start IVP integration at each ramp timestop#25
Merged
Ickaser merged 5 commits intoLyoHUB:mainfrom Mar 31, 2026
Merged
Conversation
…Tsh and pch changes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To fully solve #23 , ended up stopping and starting
solve_ivpat eachTshandpchtimestop. This imitates the previous behavior, where the derivative discontinuities inTshetc. are not smoothed out by the IVP integration. I might be inclined to allow that smoothing except that it's not systematic in any way; in Julia I set these timestops so that the solver guaranteed sees the discontinuity in slope.