Evaluate Tsh and Pch exactly from ramp interpolator in calc_knownRp#24
Merged
Ickaser merged 1 commit intoLyoHUB:mainfrom Mar 30, 2026
Merged
Evaluate Tsh and Pch exactly from ramp interpolator in calc_knownRp#24Ickaser merged 1 commit intoLyoHUB:mainfrom
Ickaser merged 1 commit intoLyoHUB:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #23 .
Using
solve_ivpevents doesn't force the integrator to evaluate at those events; the only way to guarantee that is to stop & start integration at those points, which becomes a much more involved procedure and not necessarily worth the effort. So this instead directly evalutes Pch and Tsh when doing interpolation, which keeps people from thinking that their input is getting mistreated (which it isn't).