fix: handle RETRO_ENVIRONMENT_SHUTDOWN in Minarch#699
Merged
frysee merged 1 commit intoLoveRetro:mainfrom Mar 28, 2026
Merged
Conversation
Cores like PRBoom that have a built-in quit menu call environ_cb(RETRO_ENVIRONMENT_SHUTDOWN) to request the frontend to exit. Minarch had no handler for this command, so the request was silently ignored, leaving the main loop spinning on a core that returns immediately from retro_run() — resulting in a frozen screen with no input response. Set quit = 1 when shutdown is requested, matching the same exit path used by Minarch's own quit menu.
Collaborator
Author
|
Yes I claude'd this. |
frysee
approved these changes
Mar 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
RETRO_ENVIRONMENT_SHUTDOWN(cmd 7), causing cores with built-in quit menus (e.g. PRBoom/Doom) to freeze the frontend instead of exiting cleanlyquit = 1, using the same exit path as its own menu quit