Merged
Conversation
The bug sneaked in as part of PR LoveRetro#573 which did have static buffers, but was reverted. Only this line seems to have sneaked in. Current main branch does not have static buffers in the resample_audio() function. Check issue LoveRetro#696 for details.
pvaibhav
changed the title
Member
|
Good catch! This might actually explain some of the semi-random crashes that have been reported. |
Author
|
😁 let’s merge this baby asap |
frysee
approved these changes
Mar 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The bug sneaked in as part of PR #573 which did have static buffers, but was reverted. Only this line seems to have sneaked in. Current main branch does not have static buffers in the resample_audio() function. Check issue #696 for details.