JavaScript TypeError: columns initialized as object instead of array#18
Merged
jissereitsma merged 1 commit intomasterfrom Mar 2, 2026
Merged
JavaScript TypeError: columns initialized as object instead of array#18jissereitsma merged 1 commit intomasterfrom
jissereitsma merged 1 commit intomasterfrom
Conversation
Problem:
- columns was initialized as an empty object {} in grid-component-type.phtml
- columns-selector-component-partial.phtml calls this.columns.forEach()
- Object.forEach() is not a function, causing TypeError and page hang
- Backend GridViewModel.getColumns() returns array of Column objects
Solution:
1. Changed columns: {} to columns: [] in grid-component-type.phtml:20
to match expected array type from backend
2. Added Array.isArray(this.columns) safety check before forEach()
in columns-selector-component-partial.phtml:15 to prevent future errors
Scan Results:
- Reviewed all .phtml files in the module for similar patterns
- All other object/array initializations are correct for their usage
- gridFilters: {} correctly used as object with bracket notation
- filters: [] correctly initialized as array in filters-component-partial
- No other array method calls on object-initialized properties found
This fix prevents the grid component from crashing when the columns
selector is initialized.
Contributor
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem:
Solution:
Scan Results:
This fix prevents the grid component from crashing when the columns selector is initialized.