Conversation
|
It's not a good idea for this crate to "officially" add a dependency on a pre-1.0 crate. it would be a semver break for tinyvec to update its bin-proto support to the next semver breaking version of bin-proto. would you mind if we document the support as "experimental" so that's it's not in the official crate API, until bin-proto becomes 1.0? |
|
Sure, that's not a problem. I'm planning to keep version 0.12 around for the foreseeable future as I've been using it quite intensively for a few months and haven't run into anything that would require a breaking change. It's a shame that this is the sort of conclusion one can often only reach after it's too late to bump up to version 1.0. |
|
It's never too late to bump to 1.0! In fact, an "empty" change being the 1.0 version bump gives people the simplest upgrade path. |
|
Yes, unless the crate is already a dependency for other crates, at which point this becomes a bigger endeavor. So unfortunately version 0.12 will be sticking around for now. |
|
I think maybe I didn't convey my point well perhaps: when it's already depended on by other crates you just bump 0.12.whatever to release 1.0 instead with no actual break, then the downstream crates just update to 1.0 without any fuss. Any time someone downstream gets a version mismatch error they can just update the version they're depending on and it's resolved in a few seconds. But I do admit it's not a totally zero amount of work. |
|
That's a fair point, but it is technically still a semver-incompatible change for the upstream crates (just by virtue of the version number changing), regardless of whether anything materially changed in the dependency. So it basically comes down to how strict the maintainers are about semver. Anyways, is this documentation change something you'd be willing to make, or should I? |
|
I'll merge this as is and then put on the finishing touches next time I sit down to check on |
2 participants
This PR also requires a MSRV of 1.60, for the same reason as #216