MenuToolbarController added and Extracted functionality from LogTabWindow#531
Merged
Hirogen merged 7 commits intoDevelopmentfrom Feb 27, 2026
Merged
MenuToolbarController added and Extracted functionality from LogTabWindow#531Hirogen merged 7 commits intoDevelopmentfrom
Hirogen merged 7 commits intoDevelopmentfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces several enhancements and refactorings across the codebase, focusing on improved file history management, encoding detection, UI event handling, and test reliability. The most notable changes are the addition of a method to remove files from the history, refactoring of encoding/preamble detection logic, and improvements to UI event wiring and resource management.
File History Management
RemoveFromFileHistorymethod toConfigManagerand theIConfigManagerinterface, allowing files to be removed from the recent file history list in a case-insensitive manner. This is now used in the UI to support history item removal. [1] [2] [3]Encoding and Stream Handling
PositionAwareStreamReaderBase: replacedDetectPreambleLengthAndEncodingwith a newDetectPreambleLengthmethod that returns both preamble length and detected encoding, and extractedDetermineEncodingas a static method. This improves clarity and testability. [1] [2] [3]Span<char>for efficiency instead of strings.UI and Event Handling
LogTabWindowto use a newMenuToolbarController, with explicit initialization and event wiring for menu, toolbar, and highlight group interactions. Added event handlers for history item clicks, removals, and highlight group selection, integrating with the new file history removal logic. [1] [2] [3] [4] [5]Resource Management and Testing
LedIndicatorServiceTestsandLogTabWindowto ensure proper cleanup of resources and prevent leaks. Updated test method calls to match new service method names (StartService,StopService). [1] [2] [3] [4] [5] [6] [7]TabControllerTestsfor consistency and reliability, including using discard assignment (_ =) and method group syntax. [1] [2] [3] [4] [5] [6] [7] [8]Code Cleanup