feat: Add host auto-discovery and xemu setup improvements#178
Merged
ReenigneArcher merged 2 commits intomasterfrom Apr 19, 2026
Merged
feat: Add host auto-discovery and xemu setup improvements#178ReenigneArcher merged 2 commits intomasterfrom
ReenigneArcher merged 2 commits intomasterfrom
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #178 +/- ##
==========================================
+ Coverage 61.82% 62.41% +0.58%
==========================================
Files 30 32 +2
Lines 4794 4898 +104
Branches 2140 2185 +45
==========================================
+ Hits 2964 3057 +93
Misses 910 910
- Partials 920 931 +11
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Introduce network host auto-discovery and integrate it into the UI and state flow. Adds src/network/host_discovery.{h,cpp} implementing mDNS/DNS-SD discovery (with an xemu 10.0.2.2 direct gateway probe fallback), plus unit tests and a test handler for scripted results. Add merge_discovered_host() to client state to merge or append discovered hosts and prefer resolved HTTP ports when pairing. Wire discovery tasks into the shell (start/finish/reset logic, threading, timeouts) and update UI copy to explain automatic discovery. Update setup-xemu.sh to preserve existing .local/xemu files by default (with --force to overwrite), copy files without clobbering, and report reuse; add helper functions and support-asset checks. Add lwIP mDNS sources to the NXDK build via CMake to support discovery. Unit tests added/updated for client_state, host discovery, and shell view behavior.
ReenigneArcher
force-pushed
the
dev
branch
2 times, most recently
from
a5fe109 to
0971dcc
Compare
Remove the xemu 10.0.2.2 direct gateway probing fallback and related HostDiscoveryMethod machinery; simplify mDNS-only discovery flow and update runtime/UI messaging. Add helper functions to normalize, sort and expose discovery behavior for host-native unit tests (trim_host_discovery_text, first_host_discovery_label, append_mdns_discovered_host, sort_discovered_hosts). Replace ad-hoc host sorting with a reusable comparator and sort helper, and make netif flag updates safer using std::byte and std::to_integer. Update tests to use new testing helpers and constant test addresses/ports. Also small docs tweak in README and include <cstddef> where needed.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Introduce network host auto-discovery and integrate it into the UI and state flow. Adds src/network/host_discovery.{h,cpp} implementing mDNS/DNS-SD discovery, plus unit tests and a test handler for scripted results. Add merge_discovered_host() to client state to merge or append discovered hosts and prefer resolved HTTP ports when pairing. Wire discovery tasks into the shell (start/finish/reset logic, threading, timeouts) and update UI copy to explain automatic discovery. Update setup-xemu.sh to preserve existing .local/xemu files by default (with --force to overwrite), copy files without clobbering, and report reuse; add helper functions and support-asset checks. Add lwIP mDNS sources to the NXDK build via CMake to support discovery. Unit tests added/updated for client_state, host discovery, and shell view behavior.
I cannot test if this actually works at the moment because xemu cannot discover a host of the NAT interface and my physical Xbox is not network connected at the moment. Will fix forward if there are issues.
Screenshot
Issues Fixed or Closed
Roadmap Issues
Type of Change
Checklist
AI Usage