Skip to content

feat: initial implementation #160

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ReenigneArcher merged 35 commits into from
Apr 18, 2026

Refactor MSYS2 detection into helper functions

e25ea15
Select commit
Loading
Failed to load commit list.
Merged

feat: initial implementation #160

Refactor MSYS2 detection into helper functions
e25ea15
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Apr 18, 2026 in 0s

61.82% (+0.42%) compared to cb3c38c

View this Pull Request on Codecov

61.82% (+0.42%) compared to cb3c38c

Details

Codecov Report

❌ Patch coverage is 69.15749% with 1036 lines in your changes missing coverage. Please review.
✅ Project coverage is 61.82%. Comparing base (cb3c38c) to head (e25ea15).
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
src/app/client_state.cpp 67.82% 221 Missing and 206 partials ⚠️
src/ui/shell_view.cpp 60.12% 66 Missing and 123 partials ⚠️
src/app/host_records.cpp 75.54% 29 Missing and 50 partials ⚠️
src/app/settings_storage.cpp 67.15% 33 Missing and 34 partials ⚠️
src/logging/logger.cpp 77.02% 23 Missing and 28 partials ⚠️
src/startup/saved_files.cpp 66.03% 8 Missing and 28 partials ⚠️
src/logging/log_file.cpp 54.54% 15 Missing and 20 partials ⚠️
src/startup/client_identity_storage.cpp 59.30% 13 Missing and 22 partials ⚠️
src/startup/cover_art_cache.cpp 69.01% 5 Missing and 17 partials ⚠️
src/startup/host_storage.cpp 57.14% 4 Missing and 14 partials ⚠️
... and 14 more
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #160      +/-   ##
==========================================
+ Coverage   61.40%   61.82%   +0.42%     
==========================================
  Files           2       30      +28     
  Lines          57     4794    +4737     
  Branches       13     2140    +2127     
==========================================
+ Hits           35     2964    +2929     
- Misses         17      910     +893     
- Partials        5      920     +915
Files with missing lines Coverage Δ
src/input/navigation_input.cpp 100.00% <100.00%> (ø)
src/network/host_pairing.cpp 43.86% <ø> (ø)
src/network/runtime_network.cpp 100.00% <100.00%> (ø)
src/platform/error_utils.h 100.00% <100.00%> (ø)
src/splash/splash_layout.cpp 92.85% <100.00%> (ø)
src/streaming/stats_overlay.cpp 100.00% <100.00%> (ø)
src/app/client_state.h 97.50% <97.50%> (ø)
src/app/host_records.h 90.90% <90.90%> (ø)
src/logging/logger.h 80.00% <80.00%> (ø)
src/network/host_pairing.h 0.00% <0.00%> (ø)
... and 20 more

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cb3c38c...e25ea15. Read the comment docs.

View more details on Codecov