Skip to content

Add a select few ai settings folders to gitignore#4089

Merged
kathyavini merged 1 commit intointegrationfrom
gitignore-ai-settings
Mar 26, 2026
Merged

Add a select few ai settings folders to gitignore#4089
kathyavini merged 1 commit intointegrationfrom
gitignore-ai-settings

Conversation

@Duncan-Brain
Copy link
Copy Markdown
Collaborator

@Duncan-Brain Duncan-Brain commented Mar 15, 2026

Description

Adds a select few ai setting to the gitignore folder.

There are many more but these are the ones we discussed adding.

Jira link:

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Passes test case
  • UI components visually reviewed on desktop view
  • UI components visually reviewed on mobile view
  • Other (please explain)

Checklist:

  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • The precommit and linting ran successfully
  • I have added or updated language tags for text that's part of the UI
  • I have ordered translation keys alphabetically (optional: run pnpm i18n to help with this)
  • I have added the GNU General Public License to all new files

@Duncan-Brain Duncan-Brain requested review from a team as code owners March 15, 2026 02:06
@Duncan-Brain Duncan-Brain requested review from SayakaOno and removed request for a team March 15, 2026 02:06
@Duncan-Brain Duncan-Brain self-assigned this Mar 15, 2026
Copy link
Copy Markdown
Collaborator

@SayakaOno SayakaOno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you Duncan!
@kathyavini Would you be able to check this? I haven’t had these files generated on my end yet 🙏

Copy link
Copy Markdown
Collaborator

@kathyavini kathyavini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works from the Claude end! @Duncan-Brain do you know how you came to decide on the .copilot folder though? I think the current GitHub copilot docs reference files under .github (.github/instructions and .github/prompts etc.) so just want to make sure that .copilot folder is an existing convention as well; not seeing it in the docs.

Comment thread .gitignore
# AI settings
.claude
CLAUDE.md
.copilot No newline at end of file
Copy link
Copy Markdown
Collaborator

@kathyavini kathyavini Mar 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did your copilot generate a .copilot folder at some point? Or did you create one manually? I think the official convention is now always nesting under .github/, i.e. .github/copilot-instructions.md and .github/instructions/ (based on this GitHub documentation).

I don't use repo-level instructions like that, but I did end up with a .github/prompts/ as well from using the VS Code planning mode so maybe that could be added too?

Copy link
Copy Markdown
Collaborator Author

@Duncan-Brain Duncan-Brain Mar 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is what we discussed, it was not generated, I saw it under other filenames as well.. we seemed to choose this on call!

Edit: I personally had mine under .github at time we discussed. But we do put a lot of actually useful stuff in there that the suggestion on call to use a copilot was fine

Comment thread .gitignore

# AI settings
.claude
CLAUDE.md
Copy link
Copy Markdown
Collaborator

@kathyavini kathyavini Mar 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought we left the conversation saying we would nest CLAUDE.md under .claude/ so we only need to .gitignore .claude/ (or at least, I moved my CLAUDE.md file subsequent to that tech daily convo 😂). The root level CLAUDE.md might make more sense if we ever wanted to share / commit one to repo.

It works from either place though so this is also good; we can always un-ignore at the point of sharing if we decide we want to do that.

Copy link
Copy Markdown
Collaborator Author

@Duncan-Brain Duncan-Brain Mar 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed but I thought we were doing both based on convo last time -- can edit as things change... this is a starting point

@kathyavini kathyavini added this pull request to the merge queue Mar 26, 2026
Merged via the queue into integration with commit 67d12fb Mar 26, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants