Skip to content

fix: table2 wrapper does not respect parent container width#7169

Merged
Eetwalt merged 3 commits intomainfrom
wrap-better
Mar 12, 2026
Merged

fix: table2 wrapper does not respect parent container width#7169
Eetwalt merged 3 commits intomainfrom
wrap-better

Conversation

@ElectricalBoy
Copy link
Copy Markdown
Collaborator

Summary

reported on discord: https://discord.com/channels/93055209017729024/1474351702638460968/1476543095163195432

How did you test this change?

browser dev tools

@ElectricalBoy ElectricalBoy requested review from a team as code owners February 26, 2026 12:12
@ElectricalBoy ElectricalBoy added the stylesheets Changes to stylesheets label Feb 26, 2026
@Eetwalt
Copy link
Copy Markdown
Collaborator

Eetwalt commented Feb 26, 2026

This makes every table2 as wide as possible right?

I think most tables are better to be as narrow as possible without it being dependent on a fixed width of it's container.

Couple examples:

image image

I wonder if there's a good middle ground here, as I get the issue this solves too

@Eetwalt
Copy link
Copy Markdown
Collaborator

Eetwalt commented Feb 26, 2026

Could be a prop like stretch = true or inheritWidth = true that sets this css instead of it being the default?

@ElectricalBoy
Copy link
Copy Markdown
Collaborator Author

I wonder if there's a good middle ground here, as I get the issue this solves too

the middle ground would be max-width: stretch while keeping width: fit-content
problem here is that firefox simply doesn't support max-width: stretch (not even non-standard alias!) :/

@Eetwalt
Copy link
Copy Markdown
Collaborator

Eetwalt commented Feb 27, 2026

I wonder if there's a good middle ground here, as I get the issue this solves too

the middle ground would be max-width: stretch while keeping width: fit-content problem here is that firefox simply doesn't support max-width: stretch (not even non-standard alias!) :/

I think this is still more sensible default for most use cases than having width: stretch

@Eetwalt Eetwalt merged commit 073c56e into main Mar 12, 2026
7 checks passed
@Eetwalt Eetwalt deleted the wrap-better branch March 12, 2026 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stylesheets Changes to stylesheets

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants