Adding engines to prevent installation for unsupported nodejs versions#14
Open
fantaJinMode wants to merge 1 commit intoLinkForty:mainfrom
Open
Adding engines to prevent installation for unsupported nodejs versions#14fantaJinMode wants to merge 1 commit intoLinkForty:mainfrom
fantaJinMode wants to merge 1 commit intoLinkForty:mainfrom
Conversation
|
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds an
enginesfield topackage.jsondeclaring minimum supported runtime versions, preventing installation on incompatible Node.js or npm versions.Why It Was Needed
The project requires Node.js 18+ (documented in prerequisites) but nothing enforced this at install time. Consumers on older Node.js versions could install the package and encounter runtime failures with no clear indication of the root cause.
Benefits
engine-strict) on unsupported Node.js/npm versionsType of Change
Changes Made
"engines": { "node": ">=18", "npm": ">=9" }topackage.jsonTesting
Successfully run
npm run buildnpm test)npm run typecheck)Checklist
feat:,fix:)Breaking Changes
None