Skip to content

Adding @types/qrcode to dev dependencies#13

Open
fantaJinMode wants to merge 1 commit intoLinkForty:mainfrom
fantaJinMode:qrcode_types_to_dev_dependencies
Open

Adding @types/qrcode to dev dependencies#13
fantaJinMode wants to merge 1 commit intoLinkForty:mainfrom
fantaJinMode:qrcode_types_to_dev_dependencies

Conversation

@fantaJinMode
Copy link
Contributor

Description

Moves @types/qrcode from dependencies to devDependencies, since type-only packages are only needed at build time and should not be shipped to consumers.

Why It Was Needed

Type definition packages (@types/*) are compile-time artifacts. Including them in dependencies causes them to be installed by downstream consumers unnecessarily, bloating their node_modules with packages that provide no runtime value.

Benefits

  • Reduces consumer install size
  • Aligns with standard Node.js package conventions for type-only packages
  • Consistent with how other @types/* packages are already declared in this project

Type of Change

  • 🐛 Bug fix (non-breaking change which fixes an issue)
  • ✨ New feature (non-breaking change which adds functionality)
  • 💥 Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • 📝 Documentation update
  • ♻️ Code refactoring
  • ⚡ Performance improvement
  • ✅ Test addition or update

Changes Made

  • Removed @types/qrcode from dependencies
  • Added @types/qrcode to devDependencies at the same version (^1.5.6)

Testing

Tested running npm run build successfully

  • Tests pass locally (npm test)
  • New tests added for new functionality
  • Existing tests updated (if needed)
  • Type checking passes (npm run typecheck)

Checklist

  • My code follows the project's code style
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings or errors
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published
  • I have used conventional commit messages (e.g., feat:, fix:)
  • I have signed the Contributor License Agreement (the CLA bot will prompt you)

Breaking Changes

None

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@codecov
Copy link

codecov bot commented Mar 11, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants