Adding @types/qrcode to dev dependencies#13
Open
fantaJinMode wants to merge 1 commit intoLinkForty:mainfrom
Open
Adding @types/qrcode to dev dependencies#13fantaJinMode wants to merge 1 commit intoLinkForty:mainfrom
fantaJinMode wants to merge 1 commit intoLinkForty:mainfrom
Conversation
|
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Moves
@types/qrcodefromdependenciestodevDependencies, since type-only packages are only needed at build time and should not be shipped to consumers.Why It Was Needed
Type definition packages (
@types/*) are compile-time artifacts. Including them independenciescauses them to be installed by downstream consumers unnecessarily, bloating theirnode_moduleswith packages that provide no runtime value.Benefits
@types/*packages are already declared in this projectType of Change
Changes Made
@types/qrcodefromdependencies@types/qrcodetodevDependenciesat the same version (^1.5.6)Testing
Tested running
npm run buildsuccessfullynpm test)npm run typecheck)Checklist
feat:,fix:)Breaking Changes
None