Open
Conversation
shilangyu
force-pushed
the
mw/meta-engine
branch
from
675a141 to
62d0101
Compare
shilangyu
force-pushed
the
mw/exact-literals
branch
from
3a3317c to
104d333
Compare
shilangyu
force-pushed
the
mw/exact-literals
branch
from
16c2994 to
40d68b5
Compare
shilangyu
force-pushed
the
mw/exact-literals
branch
from
40d68b5 to
8b8fd17
Compare
Member
Author
|
I pushed one new things: I now return |
Collaborator
|
Looks good! What was the initial reasoning for Unknown? Was it because you anticipated an issue with the exact literal optimization, but actually it does not matter because you check for assertions anyway? |
Member
Author
Yes, that was exactly the reason. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ready for review. Marked as draft to not merge it because the branch is based on the mw/meta-engine branch for which there is a PR.