Conversation
Contributor
Author
|
Support custom HTML markers via markerHtml instead of getMarkerHtml |
namlh023
commented
Apr 29, 2026
mauw-paloit
reviewed
May 5, 2026
| icon: L.divIcon({ | ||
| html, | ||
| className: className || "", | ||
| iconSize: [1, 1], |
Contributor
There was a problem hiding this comment.
this is an abnormally small iconSize and might cause issues with click hitboxes. Can refer to the markerFrom function to reference how it manages iconSize. Same for iconAnchor.
Contributor
Author
There was a problem hiding this comment.
Remove iconSize and let the consumer control the size of the custom marker. Set iconAnchor to (0, 0) by default. If we need to control the anchor position in the future, we can enhance it by adding width and height props as options.
| mockReverseGeoCodeResponse, | ||
| mockStaticMapDataUri, | ||
| } from "./mock-values"; | ||
| import * as markerHelper from "../../../../components/fields/location-field/location-modal/location-picker/helper"; |
Contributor
There was a problem hiding this comment.
nit but could you sort the imports
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Custom HTML markers can be rendered by passing a markerHtml property for each marker. This HTML string is used to display a custom marker, enabling dynamic rendering based on pin data—for example, showing different icons or badges for various location types
Changelog entry
Additional information