Skip to content

Fix click trigger from sortable DataTable header#1174

Open
qroll wants to merge 1 commit into
masterfrom
fix-data-table-sort
Open

Fix click trigger from sortable DataTable header#1174
qroll wants to merge 1 commit into
masterfrom
fix-data-table-sort

Conversation

@qroll
Copy link
Copy Markdown
Contributor

@qroll qroll commented May 13, 2026

Type of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing apis or functionality to change)

Description of changes

  • Add missed out click handler for the header container
  • Ensure button trigger does not trigger onHeaderClick twice

Checklist

  • Changes follow the project guidelines in CONTRIBUTING.md and CONVENTIONS.md
  • Looks good on mobile and tablet
  • Updated documentation
  • Added/updated tests

Screenshots

Screen.Recording.2026-05-13.at.8.23.02.PM.mov

@qroll qroll added this to the v3.4.0-canary.4 milestone May 13, 2026
@qroll qroll added the type: bug Something isn't working label May 13, 2026
@qroll qroll marked this pull request as ready for review May 14, 2026 03:14
@qroll qroll requested review from ghazwan-gt and zhaoyanxzy May 14, 2026 03:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type: bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant