Skip to content

[BOOKINGSG-9326][GZ] fix invalid unit value & improve e2e in Menu#1173

Open
ghazwan-gt wants to merge 4 commits into
pre-release/v4from
BOOKINGSG-9326/menu
Open

[BOOKINGSG-9326][GZ] fix invalid unit value & improve e2e in Menu#1173
ghazwan-gt wants to merge 4 commits into
pre-release/v4from
BOOKINGSG-9326/menu

Conversation

@ghazwan-gt
Copy link
Copy Markdown

Type of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing apis or functionality to change)

Description of changes

  • Fixed double px unit value
  • Added mobile view snapshot in e2e
  • Removed unused locators
  • Update snapshots filename to avoid repeated term

Checklist

  • Changes follow the project guidelines in CONTRIBUTING.md and CONVENTIONS.md
  • Looks good on mobile and tablet
  • Updated documentation
  • Added/updated tests

Screenshots
Before (right) & After (left)
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants