[BOOKINGSG-9244][RYN] migrate navbar component#1171
Open
ryan-nguyen-t wants to merge 11 commits into
Open
Conversation
added 8 commits
May 13, 2026 12:00
ryan-nguyen-t
force-pushed
the
BOOKINGSG-9244/navbar
branch
from
4ca7093 to
989818a
Compare
ryan-nguyen-t
requested review from
ghazwan-gt,
iant-gds,
zhaoyanxzy and
ziggyzet
ghazwan-gt
reviewed
May 13, 2026
| export const containerShown = css` | ||
| visibility: visible; | ||
| right: 0; | ||
| transition: all 300ms ${Motion["ease-entrance"]}; |
There was a problem hiding this comment.
@qroll is it possible to change this to one of our motion tokens? And is there any design reference we can check for animations?
The secondary brand is overflowing |
Author
|
@ghazwan-gt What screen size are you referring to for the overflowing brand |
ryan-nguyen-t
force-pushed
the
BOOKINGSG-9244/navbar
branch
from
ad2f991 to
9910eb5
Compare
ziggyzet
approved these changes
May 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
classNameis chained correctly withclsx