[BOOKINGSG-9236] migrate data table to linaria css#1170
Open
ghazwan-gt wants to merge 22 commits into
Open
Conversation
ghazwan-gt
requested review from
iant-gds,
qroll,
ryan-nguyen-t,
zhaoyanxzy and
ziggyzet
qroll
requested changes
May 13, 2026
qroll
reviewed
May 13, 2026
qroll
requested changes
May 13, 2026
Comment on lines
+102
to
+110
| test.describe(() => { | ||
| test.beforeEach(async ({ story }) => { | ||
| await story.init("default", { mode: "dark" }); | ||
| }); | ||
|
|
||
| test("Default Dark Mode", async ({ story }) => { | ||
| await compareScreenshot(story, "mount"); | ||
| }); | ||
| }); |
Contributor
There was a problem hiding this comment.
move this out of the describe block so that the beforeEach from the other test doesn't run twice
Comment on lines
+145
to
+147
| test.beforeEach(async ({ story }) => { | ||
| await story.init("alternating-rows", { mode: "dark" }); | ||
| }); |
Contributor
There was a problem hiding this comment.
same here, and for action bar
Contributor
There was a problem hiding this comment.
hmmm this screenshot shouldn't be in dark mode
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
classNameis chained correctly withclsx