[BOOKINGSG-9241][IT] Migrate footer component#1148
Merged
Conversation
iant-gds
requested review from
ghazwan-gt,
qroll,
ryan-nguyen-t,
zhaoyanxzy and
ziggyzet
qroll
requested changes
May 5, 2026
ziggyzet
reviewed
May 5, 2026
qroll
requested changes
May 6, 2026
ghazwan-gt
reviewed
May 6, 2026
ghazwan-gt
reviewed
May 6, 2026
This part (right) is different from the prod (left)
|
ghazwan-gt
reviewed
May 6, 2026
This one still happening |
qroll
requested changes
May 12, 2026
ghazwan-gt
approved these changes
May 12, 2026
qroll
reviewed
May 12, 2026
Comment on lines
+32
to
+33
| const searchParams = useSearchParams(); | ||
| const themeParam = searchParams.get("theme"); |
Contributor
There was a problem hiding this comment.
there's a typescript error here that's causing the build to fail
Author
There was a problem hiding this comment.
Hmm.. i don't see any typescript errors in my IDE thoughh
…ns to class names
qroll
reviewed
May 13, 2026
qroll
approved these changes
May 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
classNameis chained correctly withclsx- [ ] Updated Storybook documentation- [ ] Listed breaking changes