Conversation
blumix
suggested changes
Mar 6, 2020
| return false; | ||
| } | ||
|
|
||
| if (Set(key, value)) {} |
| return false; | ||
| } | ||
|
|
||
| if (Delete(key)) { |
| bool SimpleLRU::Get(const std::string &key, std::string &value) { return false; } | ||
| bool SimpleLRU::Get(const std::string &key, std::string &value) { | ||
| auto new_key = key; | ||
| auto iter = _lru_index.find(std::ref(new_key)); |
There was a problem hiding this comment.
элемент нужно переместить в начало списка на удаление
| @@ -44,19 +54,30 @@ class SimpleLRU : public Afina::Storage { | |||
| using lru_node = struct lru_node { | |||
| std::string key; | |||
| * @param key to be associated with value | ||
| * @param value to be assigned for the key | ||
| */ | ||
| void _PutWithoutCheck(const std::string &key, const std::string &value); |
xphoenix
suggested changes
Apr 14, 2020
| } | ||
|
|
||
| if (!Set(key, value)) { | ||
| _PutWithoutCheck(key, value); |
There was a problem hiding this comment.
В release сборке не проверяет лимит памяти
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.