Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BearEmotes PR Notes
Scope
This update keeps the BearEmotes emote pack intact and ports over the newer runtime behavior from the newer TwitchEmotes addon where it improves compatibility and stability.
No Bear emote entries were replaced with Twitch emotes.
Code Changes
BearEmotes/BearEmotes.luato match newer chat handling behavior used by TwitchEmotes.ChatFrame.OnEditBoxPreSendTexton Midnight builds andC_ChatInfo.SendChatMessageon non-Midnight builds.CHAT_FRAMESinstead of assumingNUM_CHAT_WINDOWS.accept_stat_updatesandBearUpdateEmoteStatsare resolved correctly instead of hitting the previous broken local-scope behavior.1instead of0.BearEmoticons_RegisterPack,BearEmotes:AddCategory, andBearEmotes:AddEmote.UI / Metadata Changes
BearEmotes/UI/BearEmotes.xmlto register in the modern Settings panel when available, with fallback to the legacy Interface Options panel.BearEmotes/UI/BearEmoteStats.xml.BearEmotes/BearEmotes.tocfor the newer interface version and addedBearEmoteStatisticstoSavedVariables.BearEmotesbundled libraries with the newerTwitchEmotescopies where they were newer.BearEmotes/libs/LibUIDropDownMenu/LibUIDropDownMenu.luato the newer upstream revision used byTwitchEmotes.BearEmotes/libs/Lib-EditBox-AutoComplete/Lib-EditBox-AutoComplete.luato the newerTwitchEmoteslogic, while keeping the Bear-specific ElvUI helper function names.Bear-Specific Fixes
BearEmotes/DropdownItems.luaso each dropdown category now has a category title entry.Stats / Animation Changes
BearEmotes/BearEmotesAnimator.luaon the newer animation loop behavior from TwitchEmotes.BearEmotes/BearEmoteStatistics.luato support filtered stat lists, a search box, and safer one-time UI element creation.