Skip to content

fix: securit audit minor issues#24

Open
pvoliveira wants to merge 2 commits into
LedgerHQ:developfrom
yldio:fix/sec-audit-report
Open

fix: securit audit minor issues#24
pvoliveira wants to merge 2 commits into
LedgerHQ:developfrom
yldio:fix/sec-audit-report

Conversation

@pvoliveira
Copy link
Copy Markdown

Checklist

  • App update process has been followed
  • Target branch is develop
  • Application version has been bumped

- potential null pointer dereference
- magic number
- duplicated code
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Apr 29, 2026

Codecov Report

❌ Patch coverage is 75.00000% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 81.15%. Comparing base (2506850) to head (52a7bbe).

Files with missing lines Patch % Lines
app/src/parser/fa2_tokens.c 50.00% 2 Missing ⚠️
app/src/parser/operation_parser.c 83.33% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop      #24      +/-   ##
===========================================
- Coverage    81.38%   81.15%   -0.23%     
===========================================
  Files           10       10              
  Lines         1934     1847      -87     
  Branches       454      444      -10     
===========================================
- Hits          1574     1499      -75     
+ Misses         348      336      -12     
  Partials        12       12              
Flag Coverage Δ
unittests 81.15% <75.00%> (-0.23%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@pvoliveira pvoliveira force-pushed the fix/sec-audit-report branch from 77ab423 to 2d1eeeb Compare April 30, 2026 13:58
@pvoliveira pvoliveira force-pushed the fix/sec-audit-report branch from 2d1eeeb to 52a7bbe Compare April 30, 2026 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants