Skip to content

App storage functionality use simplification#69

Draft
iartemov-ledger wants to merge 8 commits into
developfrom
app_storage_simple
Draft

App storage functionality use simplification#69
iartemov-ledger wants to merge 8 commits into
developfrom
app_storage_simple

Conversation

@iartemov-ledger
Copy link
Copy Markdown
Contributor

@iartemov-ledger iartemov-ledger commented Feb 20, 2025

Based on #56 and replaces it
Blocked by LedgerHQ/ledger-secure-sdk#865 or sooner a new PR targeting master
Pair review: LedgerHQ/app-boilerplate#147

Checklist

  • No N_ variables anymore, only app_storage API
  • defines accessor macros for READ and WRITE operations
  • cached in RAM config part of storage data
  • compile-time check for the data storage size
  • backup and restore tested locally with app_storage_utils.py script (again)
  • current tests fixes:
    • Stax
    • Flex
    • NanoX
    • NanoSP
    • NanoS ?
  • New --app-storage tests (requires support in Speculos )
  • rk=True workflow
  • App update process has been followed
  • Target branch is develop
  • Application version has been bumped

Comment thread Makefile Outdated
Comment thread Makefile Outdated
Comment thread include/app_storage_data.h Outdated
Comment thread src/config.c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants